Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-executer): validate user input #1610

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
enhancement

Did you add tests for your changes?
Nope

If relevant, did you update the documentation?
Nope

Summary
An in-house warning shows up if the user doesn't supply a value for required flags as part of cli-executer.

Does this PR introduce a breaking change?
Nope

Other information
N/A

alexander-akait
alexander-akait previously approved these changes Jun 4, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test it something?

@jamesgeorge007
Copy link
Member Author

We already have the unit tests for cli-executer. This one seems to be a candidate for integration tests.

alexander-akait
alexander-akait previously approved these changes Jun 4, 2020
snitin315
snitin315 previously approved these changes Jun 4, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@webpack-bot
Copy link

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@jamesgeorge007 jamesgeorge007 merged commit 3842a49 into webpack:next Jun 4, 2020
@jamesgeorge007 jamesgeorge007 deleted the feat/validate-input branch June 4, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli-executer doesn't warn if no value was provided as part of the respective flag
5 participants